Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the /Resources-entry is actually a dictionary (issue 15150) #15152

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Ensure that the /Resources-entry is actually a dictionary (issue 15150) #15152

merged 1 commit into from
Jul 8, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Prevent issues in corrupt PDF documents, if the /Resources-entry is not of the correct and expected type.

@Snuffleupagus Snuffleupagus linked an issue Jul 8, 2022 that may be closed by this pull request
Incorrect position when drawing #15150
Closed
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/050aff8041c066a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bdeccdf8f2af27b/output.txt

calixteman
calixteman approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Ensure that the /Resources-entry is actually a dictionary (issue 15150)
c2f7942 
Prevent issues in *corrupt* PDF documents, if the /Resources-entry is not of the correct and expected type.
@Snuffleupagus
Copy link
Collaborator Author

Slightly updated to unit-test, to make it clearer what's actually expected.

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/3b21b19c8656a47/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/70b2deb6690a79f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/050aff8041c066a/output.txt

Total script time: 25.91 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 21
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/050aff8041c066a/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/bdeccdf8f2af27b/output.txt

Total script time: 28.80 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/bdeccdf8f2af27b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/3b21b19c8656a47/output.txt

Total script time: 3.35 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/70b2deb6690a79f/output.txt

Total script time: 6.78 mins

  • Unit Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c8eb111e3f786cc/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/206bf8894ac2835/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c8eb111e3f786cc/output.txt

Total script time: 3.32 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 8, 2022

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/206bf8894ac2835/output.txt

Total script time: 7.56 mins

  • Unit Tests: Passed

@Snuffleupagus Snuffleupagus merged commit 4b493c2 into mozilla:master Jul 8, 2022
@Snuffleupagus Snuffleupagus deleted the validate-Resources branch July 8, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core corrupted-pdf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect position when drawing
3 participants
@Snuffleupagus @pdfjsbot @calixteman